Add constexpr support for dynamic allocated cpp_int#654
Open
marcoffee wants to merge 3 commits intoboostorg:developfrom
Open
Add constexpr support for dynamic allocated cpp_int#654marcoffee wants to merge 3 commits intoboostorg:developfrom
marcoffee wants to merge 3 commits intoboostorg:developfrom
Conversation
marcoffee
force-pushed
the
feature/more-constexpr
branch
4 times, most recently
from
66564be to
e6cb783
Compare
marcoffee
force-pushed
the
feature/more-constexpr
branch
from
e6cb783 to
2c0d0cd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #654 +/- ##
=========================================
- Coverage 94.1% 94.1% -0.0%
=========================================
Files 279 282 +3
Lines 28979 29022 +43
=========================================
+ Hits 27253 27288 +35
- Misses 1726 1734 +8
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added constexpr support for dynamic allocated
cpp_ints as long as compiler implements features__cpp_constexpr_dynamic_allocand__cpp_lib_constexpr_dynamic_allocfrom P0784R7.If those features are disabled, it behaves as the current implementation. Note that those features require C++20, so they will only work when passing
-std=c++2a(or beyond) flag during compilation through a supported compiler (tested here ong++-11+ andclang++-16+ using libstdc++ withg++-10+ toolset on ubuntu noble).It might work on
g++-10, but for some reason the b2 check forif constexprkeep returning "no" for it.Also fixed constexpr construction from strings and added some tests for construction/operations on dynamic allocated
cpp_ints.Had to make small changes to existing code to tackle some warnings given when compiled without the feature's support (such as uninitialized variables not being supported in constexpr methods before C++20).